From 43aa0a835c7518187aedab063c5e0c01d275ec00 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=B8ren=20Theilgaard?= Date: Thu, 14 Oct 2021 21:37:05 +0200 Subject: [PATCH 1/2] CONTRIBUTING.md --- CONTRIBUTING.md | 26 ++++++++++++++++++++++++++ README.md | 8 ++------ 2 files changed, 28 insertions(+), 6 deletions(-) create mode 100644 CONTRIBUTING.md diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md new file mode 100644 index 0000000..dffd930 --- /dev/null +++ b/CONTRIBUTING.md @@ -0,0 +1,26 @@ +# Contributing to Installomator + +__Please note, that if you are contributing to this project with new labels or other suggestions in PRs, please put your changes in the fragmented files, not the full `Installomator.sh` script. The full script is now a build of the fragments, and will be overwritten.__ + +We try to keep the script as short as possible, and with more than 300 labels, we can save 300 lines in the script, if we do not have credit lines on each of these. So we are thankful for your contribution, but we will be removing these lines in the coming releases. + +## Labels + +If you need a new label, please take a look at the tutorials in the Wiki, if those can be helpful for starting out on the creation of the label. + +We really encourage you to try out finding the version of the app online, so that `appNewVersion` can be filled in the label. It helps a lot when the software needs update, and greatly improve user experience. + +When creating a new label, please file a pull request (PR). And feel free to ask questions or make your comments about what else is needed, if we should take a look at the label, or help out in finding the version or isolating URLs or anything else. + +Please include the log of installing this label in the description. + +Please have one label per PR, so we can separate these. Also if you change/fix a label. + +Thank you very much! + + +## Issues + +If you encounter an issue, please file this, and include the full log of what the bug is. + +Do not use this for support, but use Slack, as described in [README.md](https://github.com/Installomator/Installomator/) diff --git a/README.md b/README.md index 36cfaba..ab031a3 100644 --- a/README.md +++ b/README.md @@ -16,13 +16,9 @@ I have put a lot of work into making it stable and safe, but I cannot - of cours Discussion, support and advice around Installomator happens in the `#installomator` channel in the [MacAdmins.org Slack](https://macadmins.org). Go there for support questions. -Do not create an issue just when you have a questions, but do file an issue or pull request for bugs or wrong behavior. When in doubt, ask in the above Slack channel. +Do not create an issue just when you have a questions, but do file an issue or pull request (PR) for bugs or wrong behavior. When in doubt, ask in the above Slack channel. -If you have added a new label, then please file a pull request. (and Thank you!) - -__Please note, that if you are contributing to this project with new labels or other suggestions in PRs, please put your changes in the fragmented files, not the full `Installomator.sh` script. The full script is now a build of the fragments, and will be overwritten.__ - -We try to keep the script as short as possible, and with more than 300 labels, we can save 300 lines in the script, if we do not have credit lines on each of these. So we are thankful for your contribution, but we will be removing these lines in the coming releases. +Please see [CONTRIBUTING.md](https://github.com/Installomator/Installomator/blob/dev/CONTRIBUTING.md) for how to contribute. ## More reading From d0e0f3e0606088b32dd420f764214494493ebb6f Mon Sep 17 00:00:00 2001 From: Adam Codega Date: Fri, 15 Oct 2021 08:58:21 -0400 Subject: [PATCH 2/2] Minor changes to verbiage around submitting issues --- CONTRIBUTING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index dffd930..fa9110a 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -21,6 +21,6 @@ Thank you very much! ## Issues -If you encounter an issue, please file this, and include the full log of what the bug is. +Do not create an issue just when you have a questions, but do file an issue or pull request (PR) for bugs or wrong behavior. Include the full log and include the version of Installomator you're running. -Do not use this for support, but use Slack, as described in [README.md](https://github.com/Installomator/Installomator/) +When in doubt, use the MacAdmins.org Slack as described in [README.md](https://github.com/Installomator/Installomator/)