From 7568cbf781eb81b9d9f7a9c3b638e0fab43cbb97 Mon Sep 17 00:00:00 2001 From: Andrew Bresee Date: Wed, 7 Sep 2016 11:11:20 -0700 Subject: [PATCH] DVCSMP-1959: Security review - removing potentially confidential log statements (#1210) * Commented out log statement logging users access token * Commented out log.info logging potentially confidential device information * Remove log logging potentially confidential information on the app --- .../smartthings/lifx-connect.src/lifx-connect.groovy | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/smartapps/smartthings/lifx-connect.src/lifx-connect.groovy b/smartapps/smartthings/lifx-connect.src/lifx-connect.groovy index 587c311..7832b68 100644 --- a/smartapps/smartthings/lifx-connect.src/lifx-connect.groovy +++ b/smartapps/smartthings/lifx-connect.src/lifx-connect.groovy @@ -50,9 +50,9 @@ def authPage() { } def description = "Tap to enter LIFX credentials" def redirectUrl = "${serverUrl}/oauth/initialize?appId=${app.id}&access_token=${state.accessToken}&apiServerUrl=${apiServerUrl}" // this triggers oauthInit() below -// def redirectUrl = "${apiServerUrl}" - log.debug "app id: ${app.id}" - log.debug "redirect url: ${redirectUrl}" + // def redirectUrl = "${apiServerUrl}" + // log.debug "app id: ${app.id}" + // log.debug "redirect url: ${redirectUrl}"s return dynamicPage(name: "Credentials", title: "Connect to LIFX", nextPage: null, uninstall: true, install:true) { section { href(url:redirectUrl, required:true, title:"Connect to LIFX", description:"Tap here to connect your LIFX account") @@ -372,7 +372,7 @@ def updateDevices() { def childDevice = getChildDevice(device.id) selectors.add("${device.id}") if (!childDevice) { - log.info("Adding device ${device.id}: ${device.product}") + // log.info("Adding device ${device.id}: ${device.product}") def data = [ label: device.label, level: Math.round((device.brightness ?: 1) * 100),