diff --git a/devicetypes/smartthings/hue-bridge.src/hue-bridge.groovy b/devicetypes/smartthings/hue-bridge.src/hue-bridge.groovy index 0986ae8..18e9a25 100644 --- a/devicetypes/smartthings/hue-bridge.src/hue-bridge.groovy +++ b/devicetypes/smartthings/hue-bridge.src/hue-bridge.groovy @@ -62,7 +62,7 @@ def parse(description) { log.trace "HUE BRIDGE, GENERATING EVENT: $map.name: $map.value" results << createEvent(name: "${map.name}", value: "${map.value}") } else { - log.trace "Parsing description" + log.trace "Parsing description" def msg = parseLanMessage(description) if (msg.body) { def contentType = msg.headers["Content-Type"] @@ -72,13 +72,13 @@ def parse(description) { log.info "Bridge response: $msg.body" } else { // Sending Bulbs List to parent" - if (parent.state.inBulbDiscovery) - log.info parent.bulbListHandler(device.hub.id, msg.body) + if (parent.isInBulbDiscovery()) + log.info parent.bulbListHandler(device.hub.id, msg.body) } } else if (contentType?.contains("xml")) { log.debug "HUE BRIDGE ALREADY PRESENT" - parent.hubVerification(device.hub.id, msg.body) + parent.hubVerification(device.hub.id, msg.body) } } } diff --git a/smartapps/smartthings/hue-connect.src/hue-connect.groovy b/smartapps/smartthings/hue-connect.src/hue-connect.groovy index 7a6e8a3..fdfb509 100644 --- a/smartapps/smartthings/hue-connect.src/hue-connect.groovy +++ b/smartapps/smartthings/hue-connect.src/hue-connect.groovy @@ -757,6 +757,10 @@ def isValidSource(macAddress) { return (vbridges?.find {"${it.value.mac}" == macAddress}) != null } +def isInBulbDiscovery() { + return state.inBulbDiscovery +} + ///////////////////////////////////// //CHILD DEVICE METHODS ///////////////////////////////////// diff --git a/smartapps/smartthings/notify-me-when.src/notify-me-when.groovy b/smartapps/smartthings/notify-me-when.src/notify-me-when.groovy index 9a55db2..3b286a8 100644 --- a/smartapps/smartthings/notify-me-when.src/notify-me-when.groovy +++ b/smartapps/smartthings/notify-me-when.src/notify-me-when.groovy @@ -111,16 +111,23 @@ private sendMessage(evt) { if (location.contactBookEnabled) { sendNotificationToContacts(msg, recipients, options) } else { - if (pushAndPhone != 'No') { - log.debug 'sending push' - options.method = 'push' - sendNotification(msg, options) - } if (phone) { options.phone = phone - log.debug 'sending SMS' - sendNotification(msg, options) + if (pushAndPhone != 'No') { + log.debug 'Sending push and SMS' + options.method = 'both' + } else { + log.debug 'Sending SMS' + options.method = 'phone' + } + } else if (pushAndPhone != 'No') { + log.debug 'Sending push' + options.method = 'push' + } else { + log.debug 'Sending nothing' + options.method = 'none' } + sendNotification(msg, options) } if (frequency) { state[evt.deviceId] = now()