MSA-2138: See my accessibzj

devicetypes/smartthings/smartsense-motion-sensor.src/smartsense-motion-sensor.groovy

@@ -173,27 +173,11 @@ private Map getBatteryResult(rawValue) {
 		} else {
 			def minVolts = 2.4
 			def maxVolts = 2.7
-			// Get the current battery percentage as a multiplier 0 - 1
+			def pct = (volts - minVolts) / (maxVolts - minVolts)
-			def curValVolts = Integer.parseInt(device.currentState("battery")?.value ?: "100") / 100.0
+			def roundedPct = Math.round(pct * 100)
-			// Find the corresponding voltage from our range
+			if (roundedPct <= 0)
-			curValVolts = curValVolts * (maxVolts - minVolts) + minVolts
+				roundedPct = 1
-			// Round to the nearest 10th of a volt
+			result.value = Math.min(100, roundedPct)
-			curValVolts = Math.round(10 * curValVolts) / 10.0
-			// Only update the battery reading if we don't have a last reading,
-			// OR we have received the same reading twice in a row
-			// OR we don't currently have a battery reading
-			// OR the value we just received is at least 2 steps off from the last reported value
-			if(state?.lastVolts == null || state?.lastVolts == volts || device.currentState("battery")?.value == null || Math.abs(curValVolts - volts) > 0.1) {
-				def pct = (volts - minVolts) / (maxVolts - minVolts)
-				def roundedPct = Math.round(pct * 100)
-				if (roundedPct <= 0)
-					roundedPct = 1
-				result.value = Math.min(100, roundedPct)
-			} else {
-				// Don't update as we want to smooth the battery values
-				result = null
-			}
-			state.lastVolts = volts
 		}
 	}
 

devicetypes/smartthings/smartsense-multi-sensor.src/smartsense-multi-sensor.groovy

@@ -275,27 +275,11 @@ private Map getBatteryResult(rawValue) {
 		} else {
 			def minVolts = 2.1
 			def maxVolts = 2.7
-			// Get the current battery percentage as a multiplier 0 - 1
+			def pct = (volts - minVolts) / (maxVolts - minVolts)
-			def curValVolts = Integer.parseInt(device.currentState("battery")?.value ?: "100") / 100.0
+			def roundedPct = Math.round(pct * 100)
-			// Find the corresponding voltage from our range
+			if (roundedPct <= 0)
-			curValVolts = curValVolts * (maxVolts - minVolts) + minVolts
+				roundedPct = 1
-			// Round to the nearest 10th of a volt
+			result.value = Math.min(100, roundedPct)
-			curValVolts = Math.round(10 * curValVolts) / 10.0
-			// Only update the battery reading if we don't have a last reading,
-			// OR we have received the same reading twice in a row
-			// OR we don't currently have a battery reading
-			// OR the value we just received is at least 2 steps off from the last reported value
-			if(state?.lastVolts == null || state?.lastVolts == volts || device.currentState("battery")?.value == null || Math.abs(curValVolts - volts) > 0.1) {
-				def pct = (volts - minVolts) / (maxVolts - minVolts)
-				def roundedPct = Math.round(pct * 100)
-				if (roundedPct <= 0)
-					roundedPct = 1
-				result.value = Math.min(100, roundedPct)
-			} else {
-				// Don't update as we want to smooth the battery values
-				result = null
-			}
-			state.lastVolts = volts
 		}
 	}
 

devicetypes/smartthings/zwave-lock.src/zwave-lock.groovy

@@ -88,21 +88,19 @@ import physicalgraph.zwave.commands.usercodev1.*
 def installed() {
 	// Device-Watch pings if no device events received for 1 hour (checkInterval)
 	sendEvent(name: "checkInterval", value: 1 * 60 * 60, displayed: false, data: [protocol: "zwave", hubHardwareId: device.hub.hardwareID])
-
-	try {
-		if (!state.init) {
-			state.init = true
-			// Wait long enough for behind-the-scenes z-wave magic to finish, but be quick enough before hub goes back into inclusion and blocks us
-			response(["delay 2000"] + secureSequence([zwave.doorLockV1.doorLockOperationGet(), zwave.batteryV1.batteryGet()], 2200))
-		}
-	} catch (e) {
-		log.warn "installed() threw $e"
-	}
 }
 
 def updated() {
 	// Device-Watch pings if no device events received for 1 hour (checkInterval)
 	sendEvent(name: "checkInterval", value: 1 * 60 * 60, displayed: false, data: [protocol: "zwave", hubHardwareId: device.hub.hardwareID])
+	try {
+		if (!state.init) {
+			state.init = true
+			response(secureSequence([zwave.doorLockV1.doorLockOperationGet(), zwave.batteryV1.batteryGet()]))
+		}
+	} catch (e) {
+		log.warn "updated() threw $e"
+	}
 }
 
 def parse(String description) {