From 5358ef94a8631fff3449f0898b5ba35a989b9955 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andre=20Schr=C3=B6ter?= Date: Sun, 13 Sep 2015 09:14:13 +0200 Subject: [PATCH] catch undefined values in reading2homekit --- platforms/FHEM.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/platforms/FHEM.js b/platforms/FHEM.js index 01b9b21..fba5d01 100644 --- a/platforms/FHEM.js +++ b/platforms/FHEM.js @@ -687,6 +687,9 @@ FHEM_dim_values = [ 'dim06%', 'dim12%', 'dim18%', 'dim25%', 'dim31%', 'dim37%', FHEMAccessory.prototype = { reading2homekit: function(reading,value) { + if( value == undefined ) + return undefined; + if( reading == 'hue' ) { value = Math.round(value * 360 / this.mappings.hue ? this.mappings.hue.max : 360); @@ -735,14 +738,13 @@ FHEMAccessory.prototype = { value = 0; } else if( reading == 'lock' ) { - if( value.match( /^locked/ ) ) + if( value.match( /uncertain/ ) ) + value = 4; + else if( value.match( /^locked/ ) ) value = 1; else value = 0; - if( value.match( /uncertain/ ) ) - value = 4; - } else if( reading == 'temperature' || reading == 'measured-temp' || reading == 'desired-temp'