mirror of
https://github.com/mtan93/homebridge.git
synced 2026-04-07 14:23:09 +01:00
Merge pull request #135 from dotsam/milight
[MiLight] Update to address correct bulbs and implement all features
This commit is contained in:
@@ -33,8 +33,7 @@ MiLight.prototype = {
|
||||
if (powerOn) {
|
||||
light.sendCommands(commands[this.type].on(this.zone));
|
||||
this.log("Setting power state to on");
|
||||
}
|
||||
else {
|
||||
} else {
|
||||
light.sendCommands(commands[this.type].off(this.zone));
|
||||
this.log("Setting power state to off");
|
||||
}
|
||||
@@ -42,18 +41,35 @@ MiLight.prototype = {
|
||||
},
|
||||
|
||||
setBrightness: function(level, callback) {
|
||||
this.log("Setting brightness to %s", level);
|
||||
if (level <= 2 && (this.type == "rgbw" || this.type == "white")) {
|
||||
// If setting brightness to 2 or lower, instead set night mode for lamps that support it
|
||||
this.log("Setting night mode", level);
|
||||
|
||||
// If this is an rgbw lamp, set the absolute brightness specified
|
||||
if (this.type == "rgbw") {
|
||||
light.sendCommands(commands.rgbw.brightness(level));
|
||||
light.sendCommands(commands[this.type].off(this.zone));
|
||||
// Not sure if this timing is going to work or not? It's supposed to be 100ms after the off command
|
||||
light.sendCommands(commands[this.type].nightMode(this.zone));
|
||||
} else {
|
||||
// If this is an rgb or a white lamp, they only support brightness up and down.
|
||||
// Set brightness up when value is >50 and down otherwise. Not sure how well this works real-world.
|
||||
if (level >= 50) {
|
||||
light.sendCommands(commands[this.type].brightUp());
|
||||
this.log("Setting brightness to %s", level);
|
||||
|
||||
// Send on command to ensure we're addressing the right bulb
|
||||
light.sendCommands(commands[this.type].on(this.zone));
|
||||
|
||||
// If this is an rgbw lamp, set the absolute brightness specified
|
||||
if (this.type == "rgbw") {
|
||||
light.sendCommands(commands.rgbw.brightness(level));
|
||||
} else {
|
||||
light.sendCommands(commands[this.type].brightDown());
|
||||
// If this is an rgb or a white lamp, they only support brightness up and down.
|
||||
// Set brightness up when value is >50 and down otherwise. Not sure how well this works real-world.
|
||||
if (level >= 50) {
|
||||
if (this.type == "white" && level == 100) {
|
||||
// But the white lamps do have a "maximum brightness" command
|
||||
light.sendCommands(commands.white.maxBright(this.zone));
|
||||
} else {
|
||||
light.sendCommands(commands[this.type].brightUp());
|
||||
}
|
||||
} else {
|
||||
light.sendCommands(commands[this.type].brightDown());
|
||||
}
|
||||
}
|
||||
}
|
||||
callback();
|
||||
@@ -62,6 +78,9 @@ MiLight.prototype = {
|
||||
setHue: function(value, callback) {
|
||||
this.log("Setting hue to %s", value);
|
||||
|
||||
// Send on command to ensure we're addressing the right bulb
|
||||
light.sendCommands(commands[this.type].on(this.zone));
|
||||
|
||||
if (this.type == "rgbw") {
|
||||
if (value == 0) {
|
||||
light.sendCommands(commands.rgbw.whiteMode(this.zone));
|
||||
|
||||
Reference in New Issue
Block a user