Protect ternary operations in configure

Protect ternary operations against order of operations, resulting in incorrect math and math against null values.

devicetypes/smartthings/aeon-multisensor-6.src/aeon-multisensor-6.groovy

@@ -29,6 +29,7 @@ metadata {
 		attribute "powerSupply", "enum", ["USB Cable", "Battery"]
 
 		fingerprint deviceId: "0x2101", inClusters: "0x5E,0x86,0x72,0x59,0x85,0x73,0x71,0x84,0x80,0x30,0x31,0x70,0x7A", outClusters: "0x5A"
+		fingerprint deviceId: "0x2101", inClusters: "0x5E,0x86,0x72,0x59,0x85,0x73,0x71,0x84,0x80,0x30,0x31,0x70,0x7A,0x5A"
 	}
 
 	simulator {
@@ -328,7 +329,7 @@ def zwaveEvent(physicalgraph.zwave.Command cmd) {
 
 def configure() {
 	// allow device user configured or default 16 min to check in; double the periodic reporting interval
-	sendEvent(name: "checkInterval", value: 2* timeOptionValueMap[reportInterval] ?: 2*8*60, displayed: false)
+	sendEvent(name: "checkInterval", value: 2* (timeOptionValueMap[reportInterval] ?: (2*8*60)), displayed: false)
 
 	// This sensor joins as a secure device if you double-click the button to include it
 	log.debug "${device.displayName} is configuring its settings"
@@ -356,7 +357,7 @@ def configure() {
 									motionSensitivity == "minimum" ? 0 : 64)
 
 	//5. report every x minutes (threshold reports don't work on battery power, default 8 mins)
-	request << zwave.configurationV1.configurationSet(parameterNumber: 111, size: 4, scaledConfigurationValue: timeOptionValueMap[reportInterval] ?: 8*60) //association group 1
+	request << zwave.configurationV1.configurationSet(parameterNumber: 111, size: 4, scaledConfigurationValue: timeOptionValueMap[reportInterval] ?: (8*60)) //association group 1
 
 	request << zwave.configurationV1.configurationSet(parameterNumber: 112, size: 4, scaledConfigurationValue: 6*60*60)  //association group 2
 

devicetypes/smartthings/smartsense-moisture-sensor.src/smartsense-moisture-sensor.groovy

@@ -255,7 +255,8 @@ private Map getBatteryResult(rawValue) {
 				def minVolts = 2.1
 				def maxVolts = 3.0
 				def pct = (volts - minVolts) / (maxVolts - minVolts)
-				result.value = Math.min(100, (int) pct * 100)
+				def roundedPct = Math.round(pct * 100)
+				result.value = Math.min(100, roundedPct)
 				result.descriptionText = "{{ device.displayName }} battery was {{ value }}%"
 			}
 		}

devicetypes/smartthings/smartsense-motion-sensor.src/smartsense-motion-sensor.groovy

@@ -271,7 +271,8 @@ private Map getBatteryResult(rawValue) {
 				def minVolts = 2.1
 				def maxVolts = 3.0
 				def pct = (volts - minVolts) / (maxVolts - minVolts)
-				result.value = Math.min(100, (int) pct * 100)
+				def roundedPct = Math.round(pct * 100)
+				result.value = Math.min(100, roundedPct)
 				result.descriptionText = "{{ device.displayName }} battery was {{ value }}%"
 			}
 		}

devicetypes/smartthings/smartsense-motion-temp-sensor.src/smartsense-motion-temp-sensor.groovy

@@ -240,7 +240,8 @@ private Map getBatteryResult(rawValue) {
 			def minVolts = 2.1
 			def maxVolts = 3.0
 			def pct = (volts - minVolts) / (maxVolts - minVolts)
-			result.value = Math.min(100, (int) pct * 100)
+			def roundedPct = Math.round(pct * 100)
+			result.value = Math.min(100, roundedPct)
 			result.descriptionText = "${linkText} battery was ${result.value}%"
 		}
 	}

devicetypes/smartthings/smartsense-multi-sensor.src/smartsense-multi-sensor.groovy

@@ -338,7 +338,8 @@ private Map getBatteryResult(rawValue) {
 				def minVolts = 2.1
 				def maxVolts = 3.0
 				def pct = (volts - minVolts) / (maxVolts - minVolts)
-				result.value = Math.min(100, (int) pct * 100)
+				def roundedPct = Math.round(pct * 100)
+				result.value = Math.min(100, roundedPct)
 				result.descriptionText = "{{ device.displayName }} battery was {{ value }}%"
 			}
 		}

devicetypes/smartthings/smartsense-open-closed-accelerometer-sensor.src/smartsense-open-closed-accelerometer-sensor.groovy

@@ -234,7 +234,8 @@ def getTemperature(value) {
 			def minVolts = 2.1
 			def maxVolts = 3.0
 			def pct = (volts - minVolts) / (maxVolts - minVolts)
-			result.value = Math.min(100, (int) pct * 100)
+			def roundedPct = Math.round(pct * 100)
+			result.value = Math.min(100, roundedPct)
 			result.descriptionText = "${linkText} battery was ${result.value}%"
 		}
 

devicetypes/smartthings/smartsense-open-closed-sensor.src/smartsense-open-closed-sensor.groovy

@@ -22,6 +22,7 @@ metadata {
 		capability "Refresh"
 		capability "Temperature Measurement"
 		capability "Health Check"
+		capability "Sensor"
 
 		command "enrollResponse"
 
@@ -229,7 +230,8 @@ private Map getBatteryResult(rawValue) {
 		def minVolts = 2.1
     	def maxVolts = 3.0
 		def pct = (volts - minVolts) / (maxVolts - minVolts)
-		result.value = Math.min(100, (int) pct * 100)
+		def roundedPct = Math.round(pct * 100)
+		result.value = Math.min(100, roundedPct)
 		result.descriptionText = "${linkText} battery was ${result.value}%"
 	}
 

devicetypes/smartthings/smartsense-temp-humidity-sensor.src/smartsense-temp-humidity-sensor.groovy

@@ -205,7 +205,8 @@ private Map getBatteryResult(rawValue) {
 		def minVolts = 2.1
     	def maxVolts = 3.0
 		def pct = (volts - minVolts) / (maxVolts - minVolts)
-		result.value = Math.min(100, (int) pct * 100)
+		def roundedPct = Math.round(pct * 100)
+		result.value = Math.min(100, roundedPct)
 		result.descriptionText = "${linkText} battery was ${result.value}%"
 	}
 

devicetypes/smartthings/tyco-door-window-sensor.src/tyco-door-window-sensor.groovy

@@ -223,7 +223,8 @@ private Map getBatteryResult(rawValue) {
 		def minVolts = 2.1
     	def maxVolts = 3.0
 		def pct = (volts - minVolts) / (maxVolts - minVolts)
-		result.value = Math.min(100, (int) pct * 100)
+		def roundedPct = Math.round(pct * 100)
+		result.value = Math.min(100, roundedPct)
 		result.descriptionText = "${linkText} battery was ${result.value}%"
 	}
 

devicetypes/smartthings/zwave-door-window-sensor.src/zwave-door-window-sensor.groovy

@@ -28,7 +28,6 @@ metadata {
 		fingerprint deviceId: "0x0701", inClusters: "0x5E,0x98"
 		fingerprint deviceId: "0x0701", inClusters: "0x5E,0x86,0x72,0x98", outClusters: "0x5A,0x82"
 		fingerprint deviceId: "0x0701", inClusters: "0x5E,0x80,0x71,0x85,0x70,0x72,0x86,0x30,0x31,0x84,0x59,0x73,0x5A,0x8F,0x98,0x7A", outClusters:"0x20" // Philio multi+
-		fingerprint deviceId: "0x0701", inClusters: "0x5E,0x72,0x5A,0x80,0x73,0x84,0x85,0x59,0x71,0x70,0x7A,0x98" // Vision door/window
 	}
 
 	// simulator metadata
@@ -36,6 +35,7 @@ metadata {
 		// status messages
 		status "open":  "command: 2001, payload: FF"
 		status "closed": "command: 2001, payload: 00"
+		status "wake up": "command: 8407, payload: "
 	}
 
 	// UI tile definitions
@@ -83,12 +83,12 @@ def updated() {
 		cmds = [
 			command(zwave.manufacturerSpecificV2.manufacturerSpecificGet()),
 			"delay 1200",
-			zwave.wakeUpV1.wakeUpNoMoreInformation()
+			zwave.wakeUpV1.wakeUpNoMoreInformation().format()
 		]
 	} else if (!state.lastbat) {
 		cmds = []
 	} else {
-		cmds = [zwave.wakeUpV1.wakeUpNoMoreInformation()]
+		cmds = [zwave.wakeUpV1.wakeUpNoMoreInformation().format()]
 	}
 	response(cmds)
 }
@@ -175,7 +175,7 @@ def zwaveEvent(physicalgraph.zwave.commands.wakeupv1.WakeUpNotification cmd)
 	if (!state.lastbat || now() - state.lastbat > 53*60*60*1000) {
 		cmds << command(zwave.batteryV1.batteryGet())
 	} else {
-		cmds << zwave.wakeUpV1.wakeUpNoMoreInformation()
+		cmds << zwave.wakeUpV1.wakeUpNoMoreInformation().format()
 	}
 	[event, response(cmds)]
 }

smartapps/smartthings/gentle-wake-up.src/gentle-wake-up.groovy

@@ -237,7 +237,7 @@ def completionPage() {
 		}
 
 		section("Notifications") {
-			input("recipients", "contact", title: "Send notifications to") {
+			input("recipients", "contact", title: "Send notifications to", required: false) {
 				input(name: "completionPhoneNumber", type: "phone", title: "Text This Number", description: "Phone number", required: false)
 				input(name: "completionPush", type: "bool", title: "Send A Push Notification", description: "Phone number", required: false)
 			}
@@ -720,7 +720,7 @@ def completionPercentage() {
 
 	def now = new Date().getTime()
 	def timeElapsed = now - atomicState.start
-	def totalRunTime = totalRunTimeMillis()
+	def totalRunTime = totalRunTimeMillis() ?: 1
 	def percentComplete = timeElapsed / totalRunTime * 100
 	log.debug "percentComplete: ${percentComplete}"
 

smartapps/smartthings/hue-connect.src/hue-connect.groovy

@@ -689,7 +689,7 @@ def parse(childDevice, description) {
             	log.warn "Parsing Body failed - trying again..."
                 poll()
             }
-            if (body instanceof java.util.HashMap) {
+            if (body instanceof java.util.Map) {
             	//poll response
                 def bulbs = getChildDevices()
                 for (bulb in body) {

smartapps/thehomeremote-homeremote/home-remote.src/home-remote.groovy

@@ -1,798 +0,0 @@
-/**
- *  Home Remote
- *
- *  Copyright 2015 The Home Remote
- *
- *  Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except
- *  in compliance with the License. You may obtain a copy of the License at:
- *
- *      http://www.apache.org/licenses/LICENSE-2.0
- *
- *  Unless required by applicable law or agreed to in writing, software distributed under the License is distributed
- *  on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License
- *  for the specific language governing permissions and limitations under the License.
- *
- */
-definition(
-    name: "Home Remote",
-    namespace: "thehomeremote.homeremote",
-    author: "The Home Remote",
-    description: "Web service that enables communication between the Home Remote app and a SmartThings hub.",
-    category: "My Apps",
-    iconUrl: "https://s3.amazonaws.com/smartapp-icons/Convenience/Cat-Convenience.png",
-    iconX2Url: "https://s3.amazonaws.com/smartapp-icons/Convenience/Cat-Convenience@2x.png",
-    iconX3Url: "https://s3.amazonaws.com/smartapp-icons/Convenience/Cat-Convenience@2x.png",
-    oauth: [displayName: "The Home Remote", displayLink: "http://thehomeremote.com/"])
-
-
-preferences {
-    section() {
-	input "accelerationSensors", "capability.accelerationSensor",title: "Acceleration Sensors", multiple: true, required: false
-	input "alarms", "capability.alarm",title: "Alarms", multiple: true, required: false
-	input "batteries", "capability.battery",title: "Batteries", multiple: true, required: false
-	input "beacons", "capability.beacon",title: "Beacons", multiple: true, required: false
-	input "buttonGroup", "capability.button",title: "Buttons", multiple: true, required: false
-	input "carbonMonoxideDetectors", "capability.carbonMonoxideDetector",title: "CO Detectors", multiple: true, required: false
-	input "colorControls", "capability.colorControl",title: "Color Lights", multiple: true, required: false
-	input "contactSensors", "capability.contactSensor",title: "Contact Sensors", multiple: true, required: false
-	input "doorControls", "capability.doorControl",title: "Door Controllers", multiple: true, required: false
-	input "energyMeters", "capability.energyMeter",title: "Energy Meters", multiple: true, required: false
-	input "illuminanceMeasurements", "capability.illuminanceMeasurement",title: "Illuminance Sensors", multiple: true, required: false
-	input "imageCaptures", "capability.imageCapture",title: "Cameras", multiple: true, required: false
-	input "locks", "capability.lock",title: "Locks", multiple: true, required: false
-	input "mediaControllers", "capability.mediaController",title: "Media Controllers", multiple: true, required: false
-	input "momentaries", "capability.momentary",title: "Momentary Buttons", multiple: true, required: false
-	input "motionSensors", "capability.motionSensor",title: "Motion Sensors", multiple: true, required: false
-	input "musicPlayers", "capability.musicPlayer",title: "Music Players", multiple: true, required: false
-	input "powerMeters", "capability.powerMeter",title: "Power Meters", multiple: true, required: false
-	input "presenceSensors", "capability.presenceSensor",title: "Presence Sensors", multiple: true, required: false
-	input "relativeHumidityMeasurements", "capability.relativeHumidityMeasurement",title: "Humidity Sensors", multiple: true, required: false
-	input "relaySwitches", "capability.relaySwitch",title: "Relays", multiple: true, required: false
-	input "signalStrengths", "capability.signalStrength",title: "Signal Strengths", multiple: true, required: false
-	input "sleepSensors", "capability.sleepSensor",title: "Sleep Sensors", multiple: true, required: false
-	input "smokeDetectors", "capability.smokeDetector",title: "Smoke Detectors", multiple: true, required: false
-	input "speechSyntheses", "capability.speechSynthesis",title: "Speech Syntheses", multiple: true, required: false
-	input "stepSensors", "capability.stepSensor",title: "Step Sensors", multiple: true, required: false
-	input "switches", "capability.switch",title: "Switches", multiple: true, required: false
-	input "switchLevels", "capability.switchLevel",title: "Dimmers", multiple: true, required: false
-	input "temperatureMeasurements", "capability.temperatureMeasurement",title: "Temperature Sensors", multiple: true, required: false
-	input "thermostats", "capability.thermostat",title: "Thermostats", multiple: true, required: false
-	input "threeAxes", "capability.threeAxis",title: "Three axis Sensors", multiple: true, required: false
-	input "tones", "capability.tone",title: "Tones", multiple: true, required: false
-	input "touchSensors", "capability.touchSensor",title: "Touch Sensors", multiple: true, required: false
-	input "valves", "capability.valve",title: "Valves", multiple: true, required: false
-	input "waterSensors", "capability.waterSensor",title: "Water Sensors", multiple: true, required: false
-    }
-}
-
-mappings {
-  path("/GetCurrentValues") {
-    action: [
-      GET: "getCurrentValues"
-    ]
-  }
-  path("/GetCurrentValuesWithDisplayName") {
-    action: [
-      GET: "getCurrentValuesWithDisplayName"
-    ]
-  }
-  path("/GetRoutines") {
-    action: [
-      GET: "getRoutines"
-    ]
-  }
-  path("/ExecuteCommand") {
-    action: [
-      PUT: "executeCommand"
-    ]
-  }
-  path("/ExecuteRoutine") {
-    action: [
-      PUT: "executeRoutine"
-    ]
-  }
-}
-
-def getCurrentValues() {
-    def resp = []    
-        
- 	accelerationSensors.each {
-      resp << [id: it.id, capability: "AccelerationSensor", attribute: "acceleration", value: it.currentValue("acceleration")]
-    }
-
-	alarms.each {
-      resp << [id: it.id, capability: "Alarm", attribute: "alarm", value: it.currentValue("alarm")]
-    }
-
-	batteries.each {
-      resp << [id: it.id, capability: "Battery", attribute: "battery", value: it.currentValue("battery")]
-    }
-
-	beacons.each {
-      resp << [id: it.id, capability: "Beacon", attribute: "presence", value: it.currentValue("presence")]
-    }
-
-	buttonGroup.each {
-      resp << [id: it.id, capability: "Button", attribute: "button", value: it.currentValue("button")]
-    }
-
-	carbonMonoxideDetectors.each {
-      resp << [id: it.id, capability: "CarbonMonoxideDetector", attribute: "carbonMonoxide", value: it.currentValue("carbonMonoxide")]
-    }
-
-	colorControls.each {
-      resp << [id: it.id, capability: "ColorControl", attribute: "hue", value: it.currentValue("hue")]
-    }
-
-	colorControls.each {
-      resp << [id: it.id, capability: "ColorControl", attribute: "saturation", value: it.currentValue("saturation")]
-    }
-
-	colorControls.each {
-      resp << [id: it.id, capability: "ColorControl", attribute: "color", value: it.currentValue("color")]
-    }
-
-	contactSensors.each {
-      resp << [id: it.id, capability: "ContactSensor", attribute: "contact", value: it.currentValue("contact")]
-    }
-
-	doorControls.each {
-      resp << [id: it.id, capability: "DoorControl", attribute: "door", value: it.currentValue("door")]
-    }
-
-	energyMeters.each {
-      resp << [id: it.id, capability: "EnergyMeter", attribute: "energy", value: it.currentValue("energy")]
-    }
-
-	illuminanceMeasurements.each {
-      resp << [id: it.id, capability: "IlluminanceMeasurement", attribute: "illuminance", value: it.currentValue("illuminance")]
-    }
-
-	imageCaptures.each {
-      resp << [id: it.id, capability: "ImageCapture", attribute: "image", value: it.currentValue("image")]
-    }
-
-	locks.each {
-      resp << [id: it.id, capability: "Lock", attribute: "lock", value: it.currentValue("lock")]
-    }
-
-	mediaControllers.each {
-      resp << [id: it.id, capability: "MediaController", attribute: "activities", value: it.currentValue("activities")]
-    }
-
-	mediaControllers.each {
-      resp << [id: it.id, capability: "MediaController", attribute: "currentActivity", value: it.currentValue("currentActivity")]
-    }
-
-	motionSensors.each {
-      resp << [id: it.id, capability: "MotionSensor", attribute: "motion", value: it.currentValue("motion")]
-    }
-
-	musicPlayers.each {
-      resp << [id: it.id, capability: "MusicPlayer", attribute: "status", value: it.currentValue("status")]
-    }
-
-	musicPlayers.each {
-      resp << [id: it.id, capability: "MusicPlayer", attribute: "level", value: it.currentValue("level")]
-    }
-
-	musicPlayers.each {
-      resp << [id: it.id, capability: "MusicPlayer", attribute: "trackDescription", value: it.currentValue("trackDescription")]
-    }
-
-	musicPlayers.each {
-      resp << [id: it.id, capability: "MusicPlayer", attribute: "trackData", value: it.currentValue("trackData")]
-    }
-
-	musicPlayers.each {
-      resp << [id: it.id, capability: "MusicPlayer", attribute: "mute", value: it.currentValue("mute")]
-    }
-
-	powerMeters.each {
-      resp << [id: it.id, capability: "PowerMeter", attribute: "power", value: it.currentValue("power")]
-    }
-
-	presenceSensors.each {
-      resp << [id: it.id, capability: "PresenceSensor", attribute: "presence", value: it.currentValue("presence")]
-    }
-
-	relativeHumidityMeasurements.each {
-      resp << [id: it.id, capability: "RelativeHumidityMeasurement", attribute: "humidity", value: it.currentValue("humidity")]
-    }
-
-	relaySwitches.each {
-      resp << [id: it.id, capability: "RelaySwitch", attribute: "switch", value: it.currentValue("switch")]
-    }
-
-	signalStrengths.each {
-      resp << [id: it.id, capability: "SignalStrength", attribute: "lqi", value: it.currentValue("lqi")]
-    }
-
-	signalStrengths.each {
-      resp << [id: it.id, capability: "SignalStrength", attribute: "rssi", value: it.currentValue("rssi")]
-    }
-
-	sleepSensors.each {
-      resp << [id: it.id, capability: "SleepSensor", attribute: "sleeping", value: it.currentValue("sleeping")]
-    }
-
-	smokeDetectors.each {
-      resp << [id: it.id, capability: "SmokeDetector", attribute: "smoke", value: it.currentValue("smoke")]
-    }
-
-	stepSensors.each {
-      resp << [id: it.id, capability: "StepSensor", attribute: "steps", value: it.currentValue("steps")]
-    }
-
-	stepSensors.each {
-      resp << [id: it.id, capability: "StepSensor", attribute: "goal", value: it.currentValue("goal")]
-    }
-
-	switches.each {
-      resp << [id: it.id, capability: "Switch", attribute: "switch", value: it.currentValue("switch")]
-    }
-
-	switchLevels.each {
-      resp << [id: it.id, capability: "SwitchLevel", attribute: "level", value: it.currentValue("level")]
-    }
-
-	temperatureMeasurements.each {
-      resp << [id: it.id, capability: "TemperatureMeasurement", attribute: "temperature", value: it.currentValue("temperature")]
-    }
-
-	thermostats.each {
-      resp << [id: it.id, capability: "Thermostat", attribute: "temperature", value: it.currentValue("temperature")]
-    }
-
-	thermostats.each {
-      resp << [id: it.id, capability: "Thermostat", attribute: "heatingSetpoint", value: it.currentValue("heatingSetpoint")]
-    }
-
-	thermostats.each {
-      resp << [id: it.id, capability: "Thermostat", attribute: "coolingSetpoint", value: it.currentValue("coolingSetpoint")]
-    }
-
-	thermostats.each {
-      resp << [id: it.id, capability: "Thermostat", attribute: "thermostatSetpoint", value: it.currentValue("thermostatSetpoint")]
-    }
-
-	thermostats.each {
-      resp << [id: it.id, capability: "Thermostat", attribute: "thermostatMode", value: it.currentValue("thermostatMode")]
-    }
-
-	thermostats.each {
-      resp << [id: it.id, capability: "Thermostat", attribute: "thermostatFanMode", value: it.currentValue("thermostatFanMode")]
-    }
-
-	thermostats.each {
-      resp << [id: it.id, capability: "Thermostat", attribute: "thermostatOperatingState", value: it.currentValue("thermostatOperatingState")]
-    }
-
-	threeAxes.each {
-      resp << [id: it.id, capability: "ThreeAxis", attribute: "threeAxis", value: it.currentValue("threeAxis")]
-    }
-
-	touchSensors.each {
-      resp << [id: it.id, capability: "TouchSensor", attribute: "touch", value: it.currentValue("touch")]
-    }
-
-	valves.each {
-      resp << [id: it.id, capability: "Valve", attribute: "contact", value: it.currentValue("contact")]
-    }
-
-	waterSensors.each {
-      resp << [id: it.id, capability: "WaterSensor", attribute: "water", value: it.currentValue("water")]
-    }
-   
-   	//resp << [id: 0, capability: "Heartbeat", attribute: "heartbeat", value: String.valueOf(state.heartbeat)]
-    
-    state.heartbeat = !state.heartbeat
-    
-    return resp
-}
-
-def getCurrentValuesWithDisplayName() {
-    def resp = []    
-        
- 	accelerationSensors.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "AccelerationSensor", attribute: "acceleration", value: it.currentValue("acceleration")]
-    }
-
-	alarms.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "Alarm", attribute: "alarm", value: it.currentValue("alarm")]
-    }
-
-	batteries.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "Battery", attribute: "battery", value: it.currentValue("battery")]
-    }
-
-	beacons.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "Beacon", attribute: "presence", value: it.currentValue("presence")]
-    }
-
-	buttonGroup.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "Button", attribute: "button", value: it.currentValue("button")]
-    }
-
-	carbonMonoxideDetectors.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "CarbonMonoxideDetector", attribute: "carbonMonoxide", value: it.currentValue("carbonMonoxide")]
-    }
-
-	colorControls.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "ColorControl", attribute: "hue", value: it.currentValue("hue")]
-    }
-
-	colorControls.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "ColorControl", attribute: "saturation", value: it.currentValue("saturation")]
-    }
-
-	colorControls.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "ColorControl", attribute: "color", value: it.currentValue("color")]
-    }
-
-	contactSensors.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "ContactSensor", attribute: "contact", value: it.currentValue("contact")]
-    }
-
-	doorControls.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "DoorControl", attribute: "door", value: it.currentValue("door")]
-    }
-
-	energyMeters.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "EnergyMeter", attribute: "energy", value: it.currentValue("energy")]
-    }
-
-	illuminanceMeasurements.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "IlluminanceMeasurement", attribute: "illuminance", value: it.currentValue("illuminance")]
-    }
-
-	imageCaptures.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "ImageCapture", attribute: "image", value: it.currentValue("image")]
-    }
-
-	locks.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "Lock", attribute: "lock", value: it.currentValue("lock")]
-    }
-
-	mediaControllers.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "MediaController", attribute: "activities", value: it.currentValue("activities")]
-    }
-
-	mediaControllers.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "MediaController", attribute: "currentActivity", value: it.currentValue("currentActivity")]
-    }
-
-	motionSensors.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "MotionSensor", attribute: "motion", value: it.currentValue("motion")]
-    }
-
-	musicPlayers.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "MusicPlayer", attribute: "status", value: it.currentValue("status")]
-    }
-
-	musicPlayers.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "MusicPlayer", attribute: "level", value: it.currentValue("level")]
-    }
-
-	musicPlayers.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "MusicPlayer", attribute: "trackDescription", value: it.currentValue("trackDescription")]
-    }
-
-	musicPlayers.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "MusicPlayer", attribute: "trackData", value: it.currentValue("trackData")]
-    }
-
-	musicPlayers.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "MusicPlayer", attribute: "mute", value: it.currentValue("mute")]
-    }
-
-	powerMeters.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "PowerMeter", attribute: "power", value: it.currentValue("power")]
-    }
-
-	presenceSensors.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "PresenceSensor", attribute: "presence", value: it.currentValue("presence")]
-    }
-
-	relativeHumidityMeasurements.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "RelativeHumidityMeasurement", attribute: "humidity", value: it.currentValue("humidity")]
-    }
-
-	relaySwitches.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "RelaySwitch", attribute: "switch", value: it.currentValue("switch")]
-    }
-
-	signalStrengths.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "SignalStrength", attribute: "lqi", value: it.currentValue("lqi")]
-    }
-
-	signalStrengths.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "SignalStrength", attribute: "rssi", value: it.currentValue("rssi")]
-    }
-
-	sleepSensors.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "SleepSensor", attribute: "sleeping", value: it.currentValue("sleeping")]
-    }
-
-	smokeDetectors.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "SmokeDetector", attribute: "smoke", value: it.currentValue("smoke")]
-    }
-
-	stepSensors.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "StepSensor", attribute: "steps", value: it.currentValue("steps")]
-    }
-
-	stepSensors.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "StepSensor", attribute: "goal", value: it.currentValue("goal")]
-    }
-
-	switches.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "Switch", attribute: "switch", value: it.currentValue("switch")]
-    }
-
-	switchLevels.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "SwitchLevel", attribute: "level", value: it.currentValue("level")]
-    }
-
-	temperatureMeasurements.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "TemperatureMeasurement", attribute: "temperature", value: it.currentValue("temperature")]
-    }
-
-	thermostats.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "Thermostat", attribute: "temperature", value: it.currentValue("temperature")]
-    }
-
-	thermostats.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "Thermostat", attribute: "heatingSetpoint", value: it.currentValue("heatingSetpoint")]
-    }
-
-	thermostats.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "Thermostat", attribute: "coolingSetpoint", value: it.currentValue("coolingSetpoint")]
-    }
-
-	thermostats.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "Thermostat", attribute: "thermostatSetpoint", value: it.currentValue("thermostatSetpoint")]
-    }
-
-	thermostats.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "Thermostat", attribute: "thermostatMode", value: it.currentValue("thermostatMode")]
-    }
-
-	thermostats.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "Thermostat", attribute: "thermostatFanMode", value: it.currentValue("thermostatFanMode")]
-    }
-
-	thermostats.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "Thermostat", attribute: "thermostatOperatingState", value: it.currentValue("thermostatOperatingState")]
-    }
-
-	threeAxes.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "ThreeAxis", attribute: "threeAxis", value: it.currentValue("threeAxis")]
-    }
-
-	touchSensors.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "TouchSensor", attribute: "touch", value: it.currentValue("touch")]
-    }
-
-	valves.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "Valve", attribute: "contact", value: it.currentValue("contact")]
-    }
-
-	waterSensors.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "WaterSensor", attribute: "water", value: it.currentValue("water")]
-    }
-   
-    momentaries.each {
-      resp << [id: it.id, displayName: it.displayName, capability: "Momentary", attribute: "", value: ""]
-    }
-   
-    //resp << [id: 0, displayName: "Heartbeat", capability: "Heartbeat", attribute: "heartbeat", value: state.heartbeat]
-    
-    return resp
-}
-
-def getDevices(capability){
-
-	def result
-
-	switch (capability) {
-    	case "Alarm":
-        	result = alarms
-        	break
-    	case "ColorControl":
-        	result = colorControls
-        	break
-    	case "DoorControl":
-        	result = doorControls
-        	break
-        case "ImageCapture":
-        	result = imageCaptures
-        	break
-    	case "Lock":
-        	result = locks
-        	break
-        case "MediaController":
-        	result = mediaControllers
-        	break
-    	case "Momentary":
-        	result = momentaries
-        	break
-        case "MusicPlayer":
-        	result = musicPlayers
-        	break
-        case "RelaySwitch":
-        	result = relaySwitches
-        	break
-    	case "SpeechSynthesis":
-        	result = speechSyntheses
-        	break
-    	case "Switch":
-        	result = switches
-        	break
-        case "SwitchLevel":
-        	result = switchLevels
-        	break
-    	case "Thermostat":
-        	result = thermostats
-        	break
-		case "ThermostatCoolingSetpoint":
-        	result = thermostatCoolingSetpoints
-        	break
-    	case "ThermostatFanMode":
-        	result = thermostatFanModes
-        	break
-        case "ThermostatHeatingSetpoint":
-        	result = thermostatHeatingSetpoints
-        	break
-    	case "ThermostatMode":
-        	result = thermostatModes
-        	break
-    	case "Tone":
-        	result = tones
-        	break
-        case "Valve":
-        	result = valves
-        	break     
-    	default:
-        	result = valves
-	}
-	return result
-}
-
-def getDoorControlCommand(value){
-	def result
-	switch (value) {
-        case "closed":
-        	result = "close"
-        	break
-    	case "open":
-        	result = "open"
-        	break
-    	default:
-        	result = value
-	}    
-	return result
-}
-
-def getLockCommand(value){
-	def result
-	switch (value) {
-        case "locked":
-        	result = "lock"
-        	break
-    	case "unlocked":
-        	result = "unlock"
-        	break
-    	default:
-        	result = value
-	}    
-	return result
-}
-
-def getMuteCommand(value){
-	def result
-	switch (value) {
-        case "muted":
-        	result = "mute"
-        	break
-    	case "unmuted":
-        	result = "unmute"
-        	break
-    	default:
-        	result = value
-	}    
-	return result
-}
-
-def getContactCommand(value){
-	def result
-	switch (value) {
-        case "closed":
-        	result = "close"
-        	break
-    	case "open":
-        	result = "open"
-        	break
-    	default:
-        	result = value
-	}    
-	return result
-}
-
-def getRoutines() {
-	return location.helloHome?.getPhrases()*.label
-}
-
-def getThermostatFanModeCommand(value){
-	def result
-	switch (value) {
-        case "on":
-        	result = "fanOn"
-        	break
-    	case "auto":
-        	result = "fanAuto"
-        	break
-    	case "circulate":
-        	result = "fanCirculate"
-        	break
-    	default:
-        	result = value
-	}    
-	return result
-}
-
-void executeCommand() {    
-    def deviceId = request.JSON?.deviceId
-    def capability = request.JSON?.capability
-    def attribute = request.JSON?.attribute 
-    def value = request.JSON?.value    
-    if (deviceId) {
-		def devices = getDevices(capability)
-        def command
-        def valueIsParameter = false
-        def valueIsInteger = false
-        switch (attribute) {    	       	
-        	case "hue":
-        		command = "setHue"
-                valueIsParameter = true
-                valueIsInteger = true
-        		break
-    		case "saturation":
-        		command = "setSaturation"
-                valueIsParameter = true
-                valueIsInteger = true
-        		break
-    		case "color":
-        		command = "setColor"
-                def rgb = hexToRgb(value)
-                def hsl = rgbToHSL(rgb)
-                value = [hue:hsl.h.toInteger(), saturation:hsl.s.toInteger()]
-                valueIsParameter = true				
-        		break
-			case "level":
-        		command = "setLevel"
-                valueIsParameter = true
-                valueIsInteger = true
-        		break            
-        	case "heatingSetpoint":
-        		command = "setHeatingSetpoint"
-                valueIsParameter = true
-        		break    
-       		case "coolingSetpoint":
-        		command = "setCoolingSetpoint"
-                valueIsParameter = true
-        		break
-          	case "currentActivity":
-        		command = "startActivity"
-                valueIsParameter = true
-        		break  
- 	  		case "door":
-        		command = getDoorControlCommand(value)
-        		break    
-      		case "lock":
-        		command = getLockCommand(value)
-        		break           
-      		case "mute":
-        		command = getMuteCommand(value)
-        		break         
-      		case "thermostatFanMode":
-        		command = getThermostatFanModeCommand(value)
-        		break         
-       		case "thermostatMode":
-        		if (value == "emergency heat") {
-                	command = "emergencyHeat"
-           		}
-                else
-                {
-                    command = value
-                }
-        		break     
-      		case "contact":
-        		command = getContactCommand(value)
-        		break
-    		default:
-        		command = value
-		}
-        devices.each {
-        	if (it.id == deviceId) {
-                // check that the device supports the specified command
-                // If not, return an error using httpError, providing a HTTP status code.
-            	if (!it.hasCommand(command)) {
-                	httpError(501, "$command is not a valid command for the device")
-            	}                
-                if(valueIsParameter){
-                	if(valueIsInteger){
-                		it."$command"(value as int)
-                	}
-                	else{
-                		it."$command"(value)
-                	}   
-                }
-                else{
-                	it."$command"()
-                }   
-           }       
-        }
-    }
-}
-
-void executeRoutine() {   
-	def routine = request.JSON?.routine
-    location.helloHome?.execute(routine)
-}
-
-def rgbToHSL(rgb) {
-	def r = rgb.r / 255
-    def g = rgb.g / 255
-    def b = rgb.b / 255
-    def h = 0
-    def s = 0
-    def l = 0
-    
-    def var_min = [r,g,b].min()
-    def var_max = [r,g,b].max()
-    def del_max = var_max - var_min
-    
-    l = (var_max + var_min) / 2
-    
-    if (del_max == 0) {
-            h = 0
-            s = 0
-    } else {
-    	if (l < 0.5) { s = del_max / (var_max + var_min) } 
-        else { s = del_max / (2 - var_max - var_min) }
-
-        def del_r = (((var_max - r) / 6) + (del_max / 2)) / del_max
-        def del_g = (((var_max - g) / 6) + (del_max / 2)) / del_max
-        def del_b = (((var_max - b) / 6) + (del_max / 2)) / del_max
-
-        if (r == var_max) { h = del_b - del_g } 
-        else if (g == var_max) { h = (1 / 3) + del_r - del_b } 
-        else if (b == var_max) { h = (2 / 3) + del_g - del_r }
-        
-		if (h < 0) { h += 1 }
-        if (h > 1) { h -= 1 }
-	}
-    def hsl = [:]    
-    hsl = [h: h * 100, s: s * 100, l: l]
-    
-    hsl
-}
-
-def hexToRgb(colorHex) {
-	def rrInt = Integer.parseInt(colorHex.substring(1,3),16)
-    def ggInt = Integer.parseInt(colorHex.substring(3,5),16)
-    def bbInt = Integer.parseInt(colorHex.substring(5,7),16)
-    
-    def colorData = [:]
-    colorData = [r: rrInt, g: ggInt, b: bbInt]
-    colorData
-}
-
-def installed() {
-	state.heartbeat = false
-}
-
-def updated() {
-	state.heartbeat = false
-}