Merge pull request #441 from tpmanley/bugfix/arrival_readattr_events

arrival: Keep 'read attr' messages from being turned into events
2026-03-09 21:03:00 +00:00 · 2016-01-15 09:51:39 -06:00 · 2016-01-14 15:34:08 -06:00 · 2016-01-13 13:20:10 -05:00 · 2016-01-11 12:10:13 -05:00
2 changed files with 5 additions and 4 deletions
--- a/devicetypes/smartthings/arrival-sensor-ha.src/arrival-sensor-ha.groovy
+++ b/devicetypes/smartthings/arrival-sensor-ha.src/arrival-sensor-ha.groovy
@@ -76,6 +76,8 @@ def parse(String description) {
    if (description?.startsWith('read attr -')) {
        handleReportAttributeMessage(description)
    }
+
+    return []
 }

 private handleReportAttributeMessage(String description) {
--- a/smartapps/smartthings/hue-connect.src/hue-connect.groovy
+++ b/smartapps/smartthings/hue-connect.src/hue-connect.groovy
@@ -258,8 +258,8 @@ def installed() {

 def updated() {
 	log.trace "Updated with settings: ${settings}"
-    unschedule()
 	unsubscribe() 
+    unschedule()    
 	initialize()
 }

@@ -325,6 +325,7 @@ def addBulbs() {
                    } else {
                        d = addChildDevice("smartthings", "Hue Bulb", dni, newHueBulb?.value.hub, ["label":newHueBulb?.value.name])
                    }
+                    log.debug "created ${d.displayName} with id $dni"
                } else {
                	log.debug "$dni in not longer paired to the Hue Bridge or ID changed"
                }
@@ -333,8 +334,6 @@ def addBulbs() {
 				newHueBulb = bulbs.find { (app.id + "/" + it.id) == dni }
 				d = addChildDevice("smartthings", "Hue Bulb", dni, newHueBulb?.hub, ["label":newHueBulb?.name])
 			}
-
-			log.debug "created ${d.displayName} with id $dni"
 			d.refresh()
 		} else {
 			log.debug "found ${d.displayName} with id $dni already exists, type: '$d.typeName'"
@@ -775,4 +774,4 @@ private Boolean hasAllHubsOver(String desiredFirmware) {

 private List getRealHubFirmwareVersions() {
 	return location.hubs*.firmwareVersionString.findAll { it }
-}
+}
Author	SHA1	Message	Date
Tom Manley	553b45a3f3	Merge pull request #441 from tpmanley/bugfix/arrival_readattr_events arrival: Keep 'read attr' messages from being turned into events	2016-01-15 09:51:39 -06:00
Tom Manley	d9ab3bca00	arrival: Keep 'read attr' messages from being turned into events Previously parse was returning null which causes the platform to create an event using the message passed to parse. We don't want that to happen so return an empty list instead. Resolves: https://smartthings.atlassian.net/browse/SMJN-38	2016-01-14 15:34:08 -06:00
Juan Pablo Risso	56cfe9e936	Merge pull request #430 from juano2310/Wemo PROB-537 - Fix error in line 337	2016-01-13 13:20:10 -05:00
Juan Risso	0d214b742e	PROB-537 - Fix error in line 337	2016-01-11 12:10:13 -05:00