Merge pull request #474 from tpmanley/bugfix/multi_cmd_failure

multi: Fix occasional failures in sending ZigBee commands during configure
2026-03-10 05:11:51 +00:00 · 2016-02-02 23:04:58 -04:00 · 2016-01-29 14:41:12 -06:00
3 changed files with 11 additions and 150 deletions
--- a/devicetypes/smartthings/smartsense-multi-sensor.src/smartsense-multi-sensor.groovy
+++ b/devicetypes/smartthings/smartsense-multi-sensor.src/smartsense-multi-sensor.groovy
@@ -441,28 +441,28 @@ def configure() {
 		"send 0x${device.deviceNetworkId} 1 ${endpointId}", "delay 500",

 		"zdo bind 0x${device.deviceNetworkId} ${endpointId} 1 1 {${device.zigbeeId}} {}", "delay 200",
-		"zcl global send-me-a-report 1 0x20 0x20 30 21600 {01}",		//checkin time 6 hrs
+		"zcl global send-me-a-report 1 0x20 0x20 30 21600 {01}", "delay 200",		//checkin time 6 hrs
 		"send 0x${device.deviceNetworkId} 1 ${endpointId}", "delay 500",

 		"zdo bind 0x${device.deviceNetworkId} ${endpointId} 1 0x402 {${device.zigbeeId}} {}", "delay 200",
-		"zcl global send-me-a-report 0x402 0 0x29 30 3600 {6400}",
+		"zcl global send-me-a-report 0x402 0 0x29 30 3600 {6400}", "delay 200",
 		"send 0x${device.deviceNetworkId} 1 ${endpointId}", "delay 500",

 		"zdo bind 0x${device.deviceNetworkId} ${endpointId} 1 0xFC02 {${device.zigbeeId}} {}", "delay 200",
-		"zcl mfg-code ${manufacturerCode}",
-		"zcl global send-me-a-report 0xFC02 0x0010 0x18 10 3600 {01}",
+		"zcl mfg-code ${manufacturerCode}", "delay 200",
+		"zcl global send-me-a-report 0xFC02 0x0010 0x18 10 3600 {01}", "delay 200",
 		"send 0x${device.deviceNetworkId} 1 ${endpointId}", "delay 500",

-		"zcl mfg-code ${manufacturerCode}",
-		"zcl global send-me-a-report 0xFC02 0x0012 0x29 1 3600 {01}",
+		"zcl mfg-code ${manufacturerCode}", "delay 200",
+		"zcl global send-me-a-report 0xFC02 0x0012 0x29 1 3600 {01}", "delay 200",
 		"send 0x${device.deviceNetworkId} 1 ${endpointId}", "delay 500",

-		"zcl mfg-code ${manufacturerCode}",
-		"zcl global send-me-a-report 0xFC02 0x0013 0x29 1 3600 {01}",
+		"zcl mfg-code ${manufacturerCode}", "delay 200",
+		"zcl global send-me-a-report 0xFC02 0x0013 0x29 1 3600 {01}", "delay 200",
 		"send 0x${device.deviceNetworkId} 1 ${endpointId}", "delay 500",

-		"zcl mfg-code ${manufacturerCode}",
-		"zcl global send-me-a-report 0xFC02 0x0014 0x29 1 3600 {01}",
+		"zcl mfg-code ${manufacturerCode}", "delay 200",
+		"zcl global send-me-a-report 0xFC02 0x0014 0x29 1 3600 {01}", "delay 200",
 		"send 0x${device.deviceNetworkId} 1 ${endpointId}", "delay 500"
 		]

@@ -481,7 +481,7 @@ def enrollResponse() {
 		"zcl global write 0x500 0x10 0xf0 {${zigbeeEui}}", "delay 200",
 		"send 0x${device.deviceNetworkId} 1 ${endpointId}", "delay 500",
 		//Enroll Response
-		"raw 0x500 {01 23 00 00 00}",
+		"raw 0x500 {01 23 00 00 00}", "delay 200",
 		"send 0x${device.deviceNetworkId} 1 1", "delay 200"
 	]
 }
--- a/smartapps/alarm/fortrezz-siren-test-by-open-and-close-sensor.src/fortrezz-siren-test-by-open-and-close-sensor.groovy
+++ b/smartapps/alarm/fortrezz-siren-test-by-open-and-close-sensor.src/fortrezz-siren-test-by-open-and-close-sensor.groovy
@@ -1,72 +0,0 @@
-/**
- *  Fortrezz siren test by open and close sensor
- *
- *  Copyright 2016 Cz
- *
- *  Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except
- *  in compliance with the License. You may obtain a copy of the License at:
- *
- *      http://www.apache.org/licenses/LICENSE-2.0
- *
- *  Unless required by applicable law or agreed to in writing, software distributed under the License is distributed
- *  on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License
- *  for the specific language governing permissions and limitations under the License.
- *
- */
-definition(
-    name: "Fortrezz siren test by open and close sensor",
-    namespace: "alarm",
-    author: "Cz",
-    description: "alarm",
-    category: "My Apps",
-    iconUrl: "https://static.wixstatic.com/media/15eeff_b050ea350d0f4733aa6a881660a2c49a.png/v1/fill/w_200,h_200,al_c/15eeff_b050ea350d0f4733aa6a881660a2c49a.png",
-    iconX2Url: "https://static.wixstatic.com/media/15eeff_b050ea350d0f4733aa6a881660a2c49a.png/v1/fill/w_200,h_200,al_c/15eeff_b050ea350d0f4733aa6a881660a2c49a.png",
-    iconX3Url: "https://static.wixstatic.com/media/15eeff_b050ea350d0f4733aa6a881660a2c49a.png/v1/fill/w_200,h_200,al_c/15eeff_b050ea350d0f4733aa6a881660a2c49a.png")
-
-
-preferences {
-	section("Siren by open and close sensor")
-     section("When Multipurpose Sencor do something"){
-    	input "theMultipurpose","capability.contactSensor",required:true,title:"which Multipurpose sensor?"
-    }
-    section("Siren or alarm"){
-        input "theAlarm","capability.alarm",required:true,title:"which switch Siren or alarm?"
-    }
-}
-
-def installed() {
-	log.debug "Installed with settings: ${settings}"
-
-	initialize()
-}
-
-def updated() {
-	log.debug "Updated with settings: ${settings}"
-
-	unsubscribe()
-	initialize()
-}
-
-def initialize() {
-	subscribe(theMultipurpose,"contact",contactHandler)
-}
-def contactHandler(evt)
-{
-	if(evt.value=="open")
-    {
-    	//theAlarm.strobe()
-        //theAlarm.siren()
-        theAlarm.both()
-        runIn(1,theAlarmoff)
-    }
-    else if(evt.value=="closed")
-    {
-    	theAlarm.off()
-    }
-}
-
-def theAlarmoff()
-{
-	theAlarm.off()
-}
-// TODO: implement event handlers
--- a/smartapps/lock/lock-test.src/lock-test.groovy
+++ b/smartapps/lock/lock-test.src/lock-test.groovy
@@ -1,67 +0,0 @@
-/**
- *  Lock Test
- *
- *  Copyright 2016 Cz
- *
- *  Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except
- *  in compliance with the License. You may obtain a copy of the License at:
- *
- *      http://www.apache.org/licenses/LICENSE-2.0
- *
- *  Unless required by applicable law or agreed to in writing, software distributed under the License is distributed
- *  on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License
- *  for the specific language governing permissions and limitations under the License.
- *
- */
-definition(
-    name: "Lock Test",
-    namespace: "Lock",
-    author: "Cz",
-    description: "Lock Test",
-    category: "My Apps",
-    iconUrl: "https://s3.amazonaws.com/smartapp-icons/Convenience/Cat-Convenience.png",
-    iconX2Url: "https://s3.amazonaws.com/smartapp-icons/Convenience/Cat-Convenience@2x.png",
-    iconX3Url: "https://s3.amazonaws.com/smartapp-icons/Convenience/Cat-Convenience@2x.png")
-
-
-preferences {
-	section("Turn on when motion detected:") {
-        input "themotion", "capability.contactSensor", required: true, title: "Where?"
-    }
-    section("Turn on the lock") {
-        input "thelock", "capability.lock", required: true,titel:"lock?"
-    }
-}
-
-def installed() {
-	log.debug "Installed with settings: ${settings}"
-
-	initialize()
-}
-
-def updated() {
-	log.debug "Updated with settings: ${settings}"
-
-	unsubscribe()
-	initialize()
-}
-
-def initialize() {
-	// TODO: subscribe to attributes, devices, locations, etc.
-     subscribe(themotion, "contact", motionAction)
-}
-
-def motionAction(evt)
-{
-	if(evt.value=="open")
-    {
-    	thelock.unlock() 
-    }
-    else if(evt.value=="closed")
-    {
-    	thelock.lock()
-    }
-    
-   	log.debug "thelock:${thelock.lock}"
-}
-// TODO: implement event handlers
Author	SHA1	Message	Date
Vinay Rao	a6bec43f2a	Merge pull request #474 from tpmanley/bugfix/multi_cmd_failure multi: Fix occasional failures in sending ZigBee commands during configure	2016-02-02 23:04:58 -04:00
Tom Manley	5ec82217ac	multi: Fix occasional failures in sending ZigBee commands during configure The missing delay after some of the commands was sometimes causing the ZigBee command to fail. Resolves: https://smartthings.atlassian.net/browse/DVCSMP-1225	2016-01-29 14:41:12 -06:00